[5.3] Update CI for php 8.4 #44494
Open
[5.3] Update CI for php 8.4 #44494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laoneo
approved these changes
Nov 21, 2024
|
Can we have tests on 8.1 AND 8.4? I'm not exactly happy when we test only on the latest version instead of at least the minimum supported version. |
|
We test php 8.1 on mysql and php 8.4 an postgresql (I hope I didn't broke this) It has been done by robert in #43863 (I think after a discussion about runtime issues for pull requests). All tests are run after merge. |
|
You need to resign the yml. |
laoneo
added
the
Updates Requested
|
And some tests are failing. |
|
yes of course see PR text and next meeting minutes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Testing Instructions
CI is green
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Have some new deprecation warnings, some of them are solved in #44489 and #44490